From 2f2239a07689daabcd1c996072efd960ae39caff Mon Sep 17 00:00:00 2001
From: Robert Kaiser <kairo@kairo.at>
Date: Mon, 20 Apr 2015 01:49:15 +0200
Subject: [PATCH] some devtools improvements

---
 LCARStrek/browser/devtools/dark-theme.css     |   1 +
 LCARStrek/browser/devtools/inspector.css      |  37 ++++++
 LCARStrek/browser/devtools/netmonitor.css     |   5 +
 .../browser/devtools/performance-icons.svg    | 108 +++++++++++-------
 LCARStrek/browser/devtools/performance.css    |  60 ++++++++++
 LCARStrek/browser/devtools/webconsole.css     |  13 ++-
 6 files changed, 181 insertions(+), 43 deletions(-)

diff --git a/LCARStrek/browser/devtools/dark-theme.css b/LCARStrek/browser/devtools/dark-theme.css
index c9ac0938..dcd62750 100644
--- a/LCARStrek/browser/devtools/dark-theme.css
+++ b/LCARStrek/browser/devtools/dark-theme.css
@@ -483,6 +483,7 @@ div.CodeMirror span.eval-text {
 }
 
 .devtools-toolbar .devtools-toolbarbutton {
+  -moz-margin-start: 2px;
 }
 
 .devtools-toolbarbutton > .toolbarbutton-icon {
diff --git a/LCARStrek/browser/devtools/inspector.css b/LCARStrek/browser/devtools/inspector.css
index 4a6c379b..2e3b0827 100644
--- a/LCARStrek/browser/devtools/inspector.css
+++ b/LCARStrek/browser/devtools/inspector.css
@@ -288,6 +288,43 @@ window {
   max-width: 200px !important;
 }
 
+/* Expand/collapse panel toolbar button */
+
+#inspector-pane-toggle {
+  list-style-image: url("debugger-collapse.png");
+  -moz-image-region: rect(0px,16px,16px,0px);
+}
+
+#inspector-pane-toggle > .toolbarbutton-icon {
+  width: 16px;
+  height: 16px;
+}
+
+#inspector-pane-toggle[pane-collapsed] {
+  list-style-image: url("debugger-expand.png");
+}
+
+#inspector-pane-toggle:hover,
+#inspector-pane-toggle:active {
+  -moz-image-region: rect(0px,32px,16px,16px);
+}
+
+@media (min-resolution: 2dppx) {
+  #inspector-pane-toggle {
+    list-style-image: url("debugger-collapse@2x.png");
+    -moz-image-region: rect(0px,32px,32px,0px);
+  }
+
+  #inspector-pane-toggle[pane-collapsed] {
+    list-style-image: url("debugger-expand@2x.png");
+  }
+
+  #inspector-pane-toggle:hover,
+  #inspector-pane-toggle:active {
+    -moz-image-region: rect(0px,64px,32px,32px);
+  }
+}
+
 /* Tooltip: Events */
 
 #devtools-tooltip-events-container {
diff --git a/LCARStrek/browser/devtools/netmonitor.css b/LCARStrek/browser/devtools/netmonitor.css
index 985e5a90..f73ddf94 100644
--- a/LCARStrek/browser/devtools/netmonitor.css
+++ b/LCARStrek/browser/devtools/netmonitor.css
@@ -194,6 +194,11 @@ window {
   width: 8em;
 }
 
+.requests-menu-transferred {
+  text-align: center;
+  width: 8em;
+}
+
 /* Network requests table: status codes */
 
 box.requests-menu-status {
diff --git a/LCARStrek/browser/devtools/performance-icons.svg b/LCARStrek/browser/devtools/performance-icons.svg
index 7c28d607..9e3adf37 100644
--- a/LCARStrek/browser/devtools/performance-icons.svg
+++ b/LCARStrek/browser/devtools/performance-icons.svg
@@ -1,42 +1,66 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="16px" height="16px">
-<style>
-  g {
-    fill: #FFCF00;
-  }
-  g:not(:target) {
-    display: none;
-  }
-</style>
-<g id="overview-markers">
-  <rect x="0px" y="3px" width="5px" height="2.5px" rx="1" ry="1"/>
-  <rect x="7px" y="3px" width="9px" height="2.5px" rx="1" ry="1"/>
-  <rect x="0px" y="7px" width="9px" height="2.5px" rx="1" ry="1"/>
-  <rect x="10px" y="7px" width="6px" height="2.5px" rx="1" ry="1"/>
-  <rect x="4px" y="11px" width="5px" height="2.5px" rx="1" ry="1"/>
-  <rect x="12px" y="11px" width="4px" height="2.5px" rx="1" ry="1"/>
-</g>
-<g id="overview-frames">
-  <rect x="1px" y="4px" width="2px" height="12px" rx="1" ry="1"/>
-  <rect x="5px" y="12px" width="2px" height="4px" rx="1" ry="1"/>
-  <rect x="9px" y="9px" width="2px" height="7px" rx="1" ry="1"/>
-  <rect x="13px" y="7px" width="2px" height="9px" rx="1" ry="1"/>
-</g>
-<g id="details-waterfall">
-  <rect x="0px" y="3px" width="9px" height="2.5px" rx="1" ry="1"/>
-  <rect x="5px" y="7px" width="8px" height="2.5px" rx="1" ry="1"/>
-  <rect x="7px" y="11px" width="9px" height="2.5px" rx="1" ry="1"/>
-</g>
-<g id="details-call-tree">
-  <rect x="0px" y="3px" width="16px" height="2px" rx="1" ry="1"/>
-  <rect x="0px" y="6px" width="8px" height="2px" rx="1" ry="1"/>
-  <rect x="0px" y="9px" width="11px" height="2px" rx="1" ry="1"/>
-  <rect x="0px" y="12px" width="6px" height="2px" rx="1" ry="1"/>
-</g>
-<g id="details-flamegraph">
-  <rect x="0px" y="3px" width="16px" height="2px" rx="1" ry="1"/>
-  <rect x="0px" y="6px" width="8px" height="2px" rx="1" ry="1"/>
-  <rect x="10px" y="6px" width="6px" height="2px" rx="1" ry="1"/>
-  <rect x="2px" y="9px" width="6px" height="2px" rx="1" ry="1"/>
-  <rect x="5px" y="12px" width="3px" height="2px" rx="1" ry="1"/>
-</g>
-</svg>
+<svg xmlns="http://www.w3.org/2000/svg"
+     xmlns:xlink="http://www.w3.org/1999/xlink"
+     width="16px" height="16px">
+<style>
+use:not(:target) {
+  display: none;
+}
+
+use {
+  fill: #FFCF00;
+}
+
+use[id$="-active"] {
+  fill: #000000;
+}
+</style>
+<defs>
+  <g id="overview-markers-shape">
+    <rect x="0px" y="3px" width="5px" height="2.5px" rx="1" ry="1"/>
+    <rect x="7px" y="3px" width="9px" height="2.5px" rx="1" ry="1"/>
+    <rect x="0px" y="7px" width="9px" height="2.5px" rx="1" ry="1"/>
+    <rect x="10px" y="7px" width="6px" height="2.5px" rx="1" ry="1"/>
+    <rect x="4px" y="11px" width="5px" height="2.5px" rx="1" ry="1"/>
+    <rect x="12px" y="11px" width="4px" height="2.5px" rx="1" ry="1"/>
+  </g>
+  <g id="overview-frames-shape">
+    <rect x="1px" y="4px" width="2px" height="12px" rx="1" ry="1"/>
+    <rect x="5px" y="12px" width="2px" height="4px" rx="1" ry="1"/>
+    <rect x="9px" y="9px" width="2px" height="7px" rx="1" ry="1"/>
+    <rect x="13px" y="7px" width="2px" height="9px" rx="1" ry="1"/>
+  </g>
+  <g id="details-waterfall-shape">
+    <rect x="0px" y="3px" width="9px" height="2.5px" rx="1" ry="1"/>
+    <rect x="5px" y="7px" width="8px" height="2.5px" rx="1" ry="1"/>
+    <rect x="7px" y="11px" width="9px" height="2.5px" rx="1" ry="1"/>
+  </g>
+  <g id="details-call-tree-shape">
+    <rect x="0px" y="3px" width="16px" height="2px" rx="1" ry="1"/>
+    <rect x="0px" y="6px" width="8px" height="2px" rx="1" ry="1"/>
+    <rect x="0px" y="9px" width="11px" height="2px" rx="1" ry="1"/>
+    <rect x="0px" y="12px" width="6px" height="2px" rx="1" ry="1"/>
+  </g>
+  <g id="details-flamegraph-shape">
+    <rect x="0px" y="3px" width="16px" height="2px" rx="1" ry="1"/>
+    <rect x="0px" y="6px" width="8px" height="2px" rx="1" ry="1"/>
+    <rect x="10px" y="6px" width="6px" height="2px" rx="1" ry="1"/>
+    <rect x="2px" y="9px" width="6px" height="2px" rx="1" ry="1"/>
+    <rect x="5px" y="12px" width="3px" height="2px" rx="1" ry="1"/>
+  </g>
+</defs>
+
+<use id="overview-markers"          xlink:href="#overview-markers-shape"/>
+<use id="overview-markers-active"   xlink:href="#overview-markers-shape"/>
+
+<use id="overview-frames"           xlink:href="#overview-frames-shape"/>
+<use id="overview-frames-active"    xlink:href="#overview-frames-shape"/>
+
+<use id="details-waterfall"         xlink:href="#details-waterfall-shape"/>
+<use id="details-waterfall-active"  xlink:href="#details-waterfall-shape"/>
+
+<use id="details-call-tree"         xlink:href="#details-call-tree-shape"/>
+<use id="details-call-tree-active"  xlink:href="#details-call-tree-shape"/>
+
+<use id="details-flamegraph"        xlink:href="#details-flamegraph-shape"/>
+<use id="details-flamegraph-active" xlink:href="#details-flamegraph-shape"/>
+</svg>
diff --git a/LCARStrek/browser/devtools/performance.css b/LCARStrek/browser/devtools/performance.css
index f0b94b54..413d8943 100644
--- a/LCARStrek/browser/devtools/performance.css
+++ b/LCARStrek/browser/devtools/performance.css
@@ -28,6 +28,30 @@
   -moz-padding-end: 8px;
 }
 
+#filter-button {
+  list-style-image: url(timeline-filter.svg#filter);
+  min-width: 24px;
+}
+
+#filter-button[disabled] {
+  list-style-image: url(timeline-filter.svg#filter-disabled);
+}
+
+#filter-button:not([disabled]):hover,
+#filter-button:not([disabled]):hover:active,
+#filter-button[open] {
+  list-style-image: url(timeline-filter.svg#filter-open);
+}
+
+#performance-filter-menupopup > menuitem:before {
+  content: "";
+  display: block;
+  width: 8px;
+  height: 8px;
+  margin: 0 8px;
+  border-radius: 1px;
+}
+
 /* Recording Notice */
 
 #performance-view .notice-container {
@@ -46,6 +70,12 @@
 /* Overview Panel */
 
 .record-button {
+  list-style-image: url(profiler-stopwatch-tbutton.svg);
+}
+
+#empty-notice > .record-button,
+.record-button:hover,
+.record-button:hover:active {
   list-style-image: url(profiler-stopwatch.svg);
 }
 
@@ -71,18 +101,48 @@
   list-style-image: url(performance-icons.svg#details-waterfall);
 }
 
+#select-waterfall-view:hover,
+#select-waterfall-view:hover:active,
+#select-waterfall-view[checked] {
+  list-style-image: url(performance-icons.svg#details-waterfall-active);
+}
+
 #select-calltree-view,
 #select-js-calltree-view,
 #select-memory-calltree-view {
   list-style-image: url(performance-icons.svg#details-call-tree);
 }
 
+#select-calltree-view:hover,
+#select-calltree-view:hover:active,
+#select-calltree-view[checked],
+#select-js-calltree-view:hover,
+#select-js-calltree-view:hover:active,
+#select-js-calltree-view[checked],
+#select-memory-calltree-view:hover,
+#select-memory-calltree-view:hover:active,
+#select-memory-calltree-view[checked] {
+  list-style-image: url(performance-icons.svg#details-call-tree-active);
+}
+
 #select-flamegraph-view,
 #select-js-flamegraph-view,
 #select-memory-flamegraph-view {
   list-style-image: url(performance-icons.svg#details-flamegraph);
 }
 
+#select-flamegraph-view:hover,
+#select-flamegraph-view:hover:active,
+#select-flamegraph-view[checked],
+#select-js-flamegraph-view:hover,
+#select-js-flamegraph-view:hover:active,
+#select-js-flamegraph-view[checked],
+#select-memory-flamegraph-view:hover,
+#select-memory-flamegraph-view:hover:active,
+#select-memory-flamegraph-view[checked] {
+  list-style-image: url(performance-icons.svg#details-flamegraph-active);
+}
+
 /* Profile call tree */
 
 .call-tree-cells-container {
diff --git a/LCARStrek/browser/devtools/webconsole.css b/LCARStrek/browser/devtools/webconsole.css
index 26827648..0de17748 100644
--- a/LCARStrek/browser/devtools/webconsole.css
+++ b/LCARStrek/browser/devtools/webconsole.css
@@ -199,6 +199,10 @@ a {
 
 /* WebConsole colored drops */
 
+.hud-console-filter-toolbar toolbarbutton > .toolbarbutton-text {
+  padding: 2px 2px 3px;
+}
+
 .webconsole-filter-button {
   -moz-user-focus: normal;
 }
@@ -209,11 +213,16 @@ a {
   height: 8px;
   width: 8px;
   border-radius: 50%;
-  margin-left: 5px;
+  -moz-margin-start: 2px;
+  -moz-margin-end: 2px;
   border-width: 1px;
   border-style: solid;
 }
 
+.webconsole-filter-button > .toolbarbutton-menubutton-button {
+  -moz-box-orient: horizontal;
+}
+
 .webconsole-filter-button menuitem {
   -moz-image-region: auto;
 }
@@ -569,6 +578,7 @@ a {
   .toolbarbutton-text {
     display: -moz-box;
   }
+  /*
   .devtools-toolbarbutton {
     margin-top: 3px;
   }
@@ -576,6 +586,7 @@ a {
   .hud-console-filter-toolbar .devtools-toolbarbutton {
     margin-top: 5px;
   }
+  */
 }
 
 /* === END webconsole.inc.css === */
-- 
2.35.3