From 0b7a8261eb31c7ef52bf2360cc58281075b80b0b Mon Sep 17 00:00:00 2001 From: Robert Kaiser Date: Sun, 15 Sep 2013 03:52:07 +0200 Subject: [PATCH] try to get around PHP strict error by not passing result of array_key directly to array_shift, which expects a reference rather than a result --- include/classes/rrdstat.php-class | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/classes/rrdstat.php-class b/include/classes/rrdstat.php-class index 3f5e98f..f0cf864 100644 --- a/include/classes/rrdstat.php-class +++ b/include/classes/rrdstat.php-class @@ -396,14 +396,15 @@ class rrdstat { $upvals[$ds['name']] = $val; } } - $key_names = (!is_numeric(array_shift(array_keys($upvals)))); + $upval_keys = array_keys($upvals); + $keys_have_names = !is_numeric(array_shift($upval_keys)); if (in_array('L', $upvals, true)) { // for at least one value, we need to set the same as the last recorded value $fvals = $this->fetch(); $rowids = array_shift($fvals); $lastvals = array_shift($fvals); foreach (array_keys($upvals, 'L') as $akey) { - $upvals[$akey] = $key_names?$lastvals[$akey]:$lastvals[$rowids[$akey]]; + $upvals[$akey] = $keys_have_names?$lastvals[$akey]:$lastvals[$rowids[$akey]]; } } $walkfunc = create_function('&$val,$key', '$val = is_numeric(trim($val))?trim($val):"U";'); @@ -411,7 +412,7 @@ class rrdstat { $return = null; if (count($upvals)) { $update_cmd = $this->rrdtool_bin.' update '.$this->rrd_file - .($key_names?' --template '.implode(':', array_keys($upvals)):'').' N:'.implode(':', $upvals); + .($keys_have_names?' --template '.implode(':', array_keys($upvals)):'').' N:'.implode(':', $upvals); $return = `$update_cmd 2>&1`; } -- 2.43.0